Fix disabled text and number property inputs by removing keypress preventDefault() calls interfering from unrelated panes. #936
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure what those preventDefault() calls were meant for exactly, but this doesn't seem to have introduced any issues thus far. A cleaner fix might be to check if e.g. the ImagePane was the target before calling preventDefault. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Commented out some preventDefault calls on keypress events that were being called from panes that weren't the target for the event.
Motivation and Context
Text and number property inputs were not functioning when a separate embeddings, text, or image pane was present and had a keypress callback handler registered to it.
Fixes #935